Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] jsx-key: incorrect behavior for checkKeyMustBeforeSpread with map callbacks #3769

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[Fix] jsx-key: incorrect behavior for checkKeyMustBeforeSpread with map callbacks #3769

merged 1 commit into from
Jun 18, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented Jun 18, 2024 •
edited by ljharb
Loading

Fixes #3742

@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (393bfa2) to head (6dc7803).

Files Patch % Lines
lib/rules/jsx-key.js 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3769      +/-   ##
==========================================
+ Coverage   94.28%   97.76%   +3.47%     
==========================================
  Files         134      134              
  Lines        9613     9617       +4     
  Branches     3486     3488       +2     
==========================================
+ Hits         9064     9402     +338     
+ Misses        549      215     -334

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the akul/jsx-key-checkKeyMustBeforeSpread-arrmap-issue branch from 0091ac8 to 6dc7803 Compare June 18, 2024 18:21
@ljharb ljharb changed the title [Fix] jsx-key: incorrect behaviour for checkKeyMustBeforeSpread with map callbacks [Fix] jsx-key: incorrect behavior for checkKeyMustBeforeSpread with map callbacks Jun 18, 2024
@ljharb ljharb merged commit 6dc7803 into jsx-eslint:master Jun 18, 2024
329 of 330 checks passed
@patooworld patooworld mentioned this pull request Jul 9, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jul 10, 2024
Open
@zdr4k zdr4k mentioned this pull request Jul 10, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jul 10, 2024
Open
This was referenced Jul 10, 2024
Open
Open
Open
Open
Open
Open
@simlarsen simlarsen mentioned this pull request Jul 11, 2024
Merged
@richyhoopd richyhoopd mentioned this pull request Jul 11, 2024
Open
@patooworld patooworld mentioned this pull request Jul 13, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 16, 2024
Open
@kalbroni7 kalbroni7 mentioned this pull request Jul 16, 2024
Open
This was referenced Jul 17, 2024
Open
Open
Open
@Balantion2020 Balantion2020 mentioned this pull request Jul 17, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jul 18, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 18, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 18, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 16, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 20, 2024
Open
This was referenced Oct 22, 2024
Open
Open
Open
Open
Open
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 25, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 26, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Oct 26, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 26, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 26, 2024
Open
@Vishesh7797 Vishesh7797 mentioned this pull request Oct 27, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 27, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 27, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 27, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Oct 28, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 31, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Nov 2, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Nov 2, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Nov 3, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Nov 7, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: checkKeyMustBeforeSpread of react/jsx-key doesn't work when generating array dynamically
2 participants
@akulsr0 @ljharb